Open
Conversation
Collaborator
|
@honarkhah I don't see an issue tracking a request for this functionality? In the context of Helm (which these official charts are working in), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
namespaceOverrideacross all charts that were missing it: fluent-bit, fluent-bit-aggregator, fluent-bit-collector, and fluentd. Thefluent-operatorchart already had this feature.This allows deploying chart resources into a namespace different from the Helm release namespace, which is useful for multi-namespace deployments and combined/umbrella charts.
Changes
_helpers.tpl: Added a<chart>.namespacetemplate helper to each chart that returns.Values.namespaceOverrideif set, otherwise falls back to.Release.Namespace.values.yaml: AddednamespaceOverridevalue (defaults to empty) to each chart.{{ .Release.Namespace }}references with{{ include "<chart>.namespace" . }}across all resource templates.Affected Charts
fluent-bitvalues.yamlfluent-bit-aggregatorvalues.yamlfluent-bit-collectorvalues.yamlfluentdvalues.yamlUsage
When
namespaceOverrideis not set, behaviour is unchanged — resources are deployed to the Helm release namespace as before.Backwards Compatibility
This change is fully backwards compatible. When
namespaceOverrideis empty or unset, the helper falls back to.Release.Namespace, preserving existing behaviour.Fixes