Conversation
This "selfoss" HTML template is enhanced for performance and accessibility. Key changes include adding lang="en" for better accessibility and a <noscript> tag to inform users when JavaScript is disabled. The viewport meta tag is streamlined for improved mobile responsiveness, and the stylesheet link is optimized for quicker rendering. JavaScript loads asynchronously, enhancing page performance, with improved error handling directing users to check logs if loading fails. These updates make "selfoss" more efficient and user-friendly across devices.
✅ Deploy Preview for selfoss canceled.
|
|
Enhanced "selfoss" HTML template for better performance and accessibility. Added lang="en" for accessibility and a tag for users with JavaScript disabled. Streamlined viewport meta tag for mobile responsiveness, optimized stylesheet link for faster loading, and asynchronous JavaScript loading with improved error handling. Overall, these updates make "selfoss" more efficient and user-friendly. |
jtojnar
left a comment
jtojnar
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution and sorry for the late response.
Could you please split each individual change into a separate commit so that it is clear to see what actually changed? It would also allow to explain the reasoning for the changes in the relevant commit message.
| <meta name="viewport" content="width=device-width, user-scalable=yes, initial-scale=1" /> | ||
|
|
||
| <!-- Add support for fullscreen Webapp on iPhone 5 --> | ||
| <meta name="viewport" content="initial-scale=1, user-scalable=yes" media="(device-height: 568px)" /> |
There was a problem hiding this comment.
Could you clarify why this is no longer needed?
| @@ -1,47 +1,41 @@ | |||
| <!doctype html> | |||
| <html> | |||
| <html lang="en"> | |||
There was a problem hiding this comment.
The application can be in different language and is set dynamically here:
selfoss/client/js/selfoss-base.js
Lines 95 to 100 in 1b2eeda
| <p id="js-loading-message">selfoss requires JavaScript to run, please enable it on this page.</p> | ||
| <noscript><p>selfoss requires JavaScript to run. Please enable it to continue.</p></noscript> | ||
|
|
||
| <p id="js-loading-message" aria-live="polite">selfoss is still loading, please wait.</p> |
There was a problem hiding this comment.
This will cause two messages will be displayed when JavaScript is disabled.
|
|
||
| <script type="text/javascript"> | ||
| <script> | ||
| document.getElementById('js-loading-message').textContent = 'selfoss is still loading, please wait.'; |
There was a problem hiding this comment.
In the current state, is not this redundant?
| <title>selfoss</title> | ||
|
|
||
| <!-- Will be substituted at request time. --> | ||
| <!-- Dynamic base path --> |
2 participants
This "selfoss" HTML template is enhanced for performance and accessibility. Key changes include adding lang="en" for better accessibility and a tag to inform users when JavaScript is disabled. The viewport meta tag is streamlined for improved mobile responsiveness, and the stylesheet link is optimized for quicker rendering. JavaScript loads asynchronously, enhancing page performance, with improved error handling directing users to check logs if loading fails. These updates make "selfoss" more efficient and user-friendly across devices.