Allows to specify index when using splunk HTTP Event collector#232
Open
william-billaud wants to merge 1 commit into
Open
Allows to specify index when using splunk HTTP Event collector#232william-billaud wants to merge 1 commit into
william-billaud wants to merge 1 commit into
Conversation
…ts + how default/possible value are presented).
Add an optionnal arguement : [INDEX]: The name of the index by which the event data is to be indexed (default: None, use token default index).
Ignored when PROTOCOL is tcp.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 84.29% 84.31% +0.02%
==========================================
Files 35 35
Lines 3756 3761 +5
==========================================
+ Hits 3166 3171 +5
Misses 590 590
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Make Splunk help more consistent with other adapter (Optional arguments + how default/possible value are presented).
Add an optional argument : [INDEX]: The name of the index by which the event data is to be indexed (default: None, use token default index). Ignored when PROTOCOL is tcp.
Test
Regarding testing :
test_dissect_records/test_dissect_json)E.g with a securelog.rec file with 9 records :
records
json