fix(menubar): refuse menubar updates from CLIs older than 0.9.9#593
Merged
Conversation
CLIs before 0.9.9 resolve /releases/latest for menubar --force, which can point at a CLI-only release with no menubar asset, so the update they run installs nothing. The update dialog and performUpdate now detect an installed CLI older than the installer fix (909efcf, first shipped in 0.9.9) and direct the user to upgrade the CLI first, with the exact command, instead of suggesting a command that cannot work. Unknown CLI versions are not flagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menubar's update dialog tells users to run
codeburn menubar --force, but CLIs older than 0.9.9 resolve/releases/latestfor that command, which can point at a CLI-only release carrying no menubar asset, so the update silently installs nothing.The app now knows the minimum CLI version that can perform the install (0.9.9, where commit 909efcf introduced the
mac-v*release scan; verifiedv0.9.8does not contain it). When the installed CLI is older, both the update dialog and the in-app update action show the exact CLI upgrade command to run first instead of a command that cannot work. Unknown or empty CLI versions are not flagged.Covered by three new UpdateChecker tests (below minimum, at/above minimum, unknown version); the full menubar suite passes (65 tests).