Skip to content

terminal: report selected match bounds#12942

Open
bo2themax wants to merge 1 commit into
ghostty-org:mainfrom
bo2themax:push-09174d3e
Open

terminal: report selected match bounds#12942
bo2themax wants to merge 1 commit into
ghostty-org:mainfrom
bo2themax:push-09174d3e

Conversation

@bo2themax
Copy link
Copy Markdown
Member

I wanted to implement findIndicator-like highlights when searching, in order to do this I need the coordinates for the selected matches, in order to apply the animation in the app.

This pr is the first step which includes the core terminal changes to report those bounds from render.

The bounds info extends current ghostty_action_search_selected_s
struct, so gtk can implement it whenever it's appropriate.

I also tried to make this as a separate event like search_selected_regions, which would still achieve the goal, but then I thought it's better to keep message together with search_selected since these bounds only make sense when the index is not null.
The result (current) is a bit more changes, but it makes more sense to me.

AI Disclosure

Claude implemented this, I read all the changes myself, and tested it as much as I can with normal search. Also different Claude sessions reviewed and refined multiple rounds based on my suggestions.

@bo2themax bo2themax requested review from a team as code owners June 6, 2026 19:24
@ghostty-bot ghostty-bot Bot added the vt Control sequence related label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vt Control sequence related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant