Added I23ZoomController to account for the differing PV names#2097
Added I23ZoomController to account for the differing PV names#2097adaudon wants to merge 5 commits into
Conversation
… zoom controller on I23.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2097 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 345 345
Lines 13472 13476 +4
=======================================
+ Hits 13358 13362 +4
Misses 114 114 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, I think that rather than make a new device it might be better to just change the ZoomController so you can specify the suffix for the percentage/level. That's what we've done in other places where they have been different. I would also suggest you ask controls to make an alias for CAM:MP:SELECT -> ZOOM:MP:SELECT, we can then reuse the device with no changes
That's fair, the initial idea was to minimise changes of common dodal files until I23 could discuss whether they wanted to change their PVs to match other beamlines or to keep it as is. But if it's better longterm then it'd be better to change the ZoomController instead. |
|
Zoom isn't required for optical centering so I23ZoomController was replaced with NullZoomController for now so I23 can decide how they want to proceed with xray centering while having access to optical centering for testing. |
Other mx-beamlines use a different PV name for zoom. Created a ZoomController specific to I23.
Fixes DiamondLightSource/mx-bluesky#1771
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}