Skip to content

BED-8189: Update default admin email#303

Merged
jeff-matthews merged 2 commits into
release/v9.4.0from
BED-8189-admin-email
Jun 30, 2026
Merged

BED-8189: Update default admin email#303
jeff-matthews merged 2 commits into
release/v9.4.0from
BED-8189-admin-email

Conversation

@jeff-matthews

@jeff-matthews jeff-matthews commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Minor doc updates for next release related to BED-8189:

  • Update the default admin email address in the shared snippet
  • Update example config with default admin email and remove deprecated field

Summary by CodeRabbit

  • Documentation
    • Updated default admin configuration example to include email_address field
    • Corrected default admin email address in sample data documentation from placeholder to standard admin email

@jeff-matthews jeff-matthews self-assigned this Jun 2, 2026
@jeff-matthews jeff-matthews added administration Docs related to managing general tenant configuration v9.3.0 labels Jun 2, 2026
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1b51ea8-f283-4474-bee6-efefae1dc274

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Two documentation snippets are updated to align the default admin email configuration: the default_admin example JSON now shows email_address instead of principal_name, and the sample data email is changed from spam@example.com to admin@example.com across both files.

Changes

Default admin email configuration

Layer / File(s) Summary
Default admin email configuration examples
docs/manage-bloodhound/bh-config.mdx, docs/snippets/sample-data.mdx
The default_admin example JSON adds email_address and removes principal_name. The sample data documentation email is updated to admin@example.com for consistency.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🐰 Two tiny docs align their admin email cheer,
From spam to admin, the path becomes clear!
No logic to test, just examples bright,
Configuration docs now look just right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the default admin email address across documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BED-8189-admin-email

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jeff-matthews

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

"connection": "postgresql://bhe:bhe4eva@localhost/bhe"
},
"default_admin": {
"principal_name": "admin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason principal_name was removed? It gets filled by default if missing, but it's an essential field and would probably be good to show in the example JSON configuration.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cami-specter, I thought I should remove it from the example because the docs above indicate that it is deprecated. Maybe that's a mistake though.

@cami-specter cami-specter Jun 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. It's definitely not deprecated in the code and in our build.config.json.template which we use to set local configs (https://github.com/SpecterOps/BloodHound/blob/main/local-harnesses/build.config.json.template#L19), but there might be context I'm not aware of. Probably best to remove it then if it's marked as such!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can find out more about why that was marked as deprecated in docs only.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to revert this change to align with the codebase.

Base automatically changed from release/v9.3.0 to main June 17, 2026 21:12
@jeff-matthews jeff-matthews changed the base branch from main to release/v9.4.0 June 30, 2026 14:03
@jeff-matthews jeff-matthews merged commit aa8ca14 into release/v9.4.0 Jun 30, 2026
3 checks passed
@jeff-matthews jeff-matthews deleted the BED-8189-admin-email branch June 30, 2026 14:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

administration Docs related to managing general tenant configuration v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants