Skip to content

refactor: Remove dead code and tidy storage-client internals#983

Open
vdusek wants to merge 7 commits into
masterfrom
refactor/cleanup-internals
Open

refactor: Remove dead code and tidy storage-client internals#983
vdusek wants to merge 7 commits into
masterfrom
refactor/cleanup-internals

Conversation

@vdusek

@vdusek vdusek commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Internal cleanup portion of the v4 major-release cleanup. No public API changes.

Dead code

  • Remove EXIT_CODE_SUCCESS, is_url(), maybe_extract_enum_member_value(), a no-op except Exception: raise in _crypto, the unused hpack/httpcore Scrapy loggers (leftovers from the old httpx stack — HTTP now goes through impit), the unused _was_final_persist_state_emitted flag, and a discarded default_kvs_client.get() call.

Tidy-ups

  • Skip the API call when push_data is given an empty list.
  • Rename hash_api_base_url_and_tokenhash_api_public_base_url_and_token to match what it hashes.

Packaging

  • Add the Typing :: Typed classifier and remove the stale apify-shared entry from [tool.uv.exclude-newer-package].

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 12, 2026
@vdusek vdusek self-assigned this Jun 12, 2026
@github-actions github-actions Bot added this to the 142nd sprint - Tooling team milestone Jun 12, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jun 12, 2026
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.92%. Comparing base (0daca28) to head (405898d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/apify/storage_clients/_apify/_dataset_client.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
+ Coverage   89.90%   89.92%   +0.01%     
==========================================
  Files          49       49              
  Lines        3091     3066      -25     
==========================================
- Hits         2779     2757      -22     
+ Misses        312      309       -3     
Flag Coverage Δ
e2e 35.97% <42.85%> (+0.06%) ⬆️
integration 57.11% <71.42%> (+0.23%) ⬆️
unit 78.63% <71.42%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek requested a review from Pijukatel June 12, 2026 16:40
@vdusek vdusek marked this pull request as ready for review June 12, 2026 16:51
vdusek added 4 commits June 12, 2026 18:56
Reverts the api_client injection into AliasResolver/open_by_alias added earlier on this branch so this PR
stays a focused dead-code cleanup; the client-lifecycle change is submitted as a separate PR per review feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants