Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app.go
Original file line number Diff line number Diff line change
Expand Up @@ -1321,6 +1321,8 @@ func (app *App) serverErrorHandler(fctx *fasthttp.RequestCtx, err error) {
err = ErrRequestEntityTooLarge
case errors.Is(err, fasthttp.ErrGetOnly):
err = ErrMethodNotAllowed
Comment thread
gaby marked this conversation as resolved.
case strings.Contains(err.Error(), "unsupported http request method"):
err = ErrNotImplemented
case strings.Contains(err.Error(), "timeout"):
err = ErrRequestTimeout
default:
Expand Down
55 changes: 55 additions & 0 deletions app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,61 @@ func Test_App_serverErrorHandler_Network_Error(t *testing.T) {
require.Equal(t, StatusBadGateway, c.fasthttp.Response.StatusCode())
}

func Test_App_serverErrorHandler_Unsupported_Method_Error(t *testing.T) {
t.Parallel()
app := New()
c := app.AcquireCtx(&fasthttp.RequestCtx{}).(*DefaultCtx) //nolint:errcheck,forcetypeassert // not needed

app.serverErrorHandler(c.fasthttp, errors.New("unsupported http request method 'FOO'"))
require.Equal(t, utils.StatusMessage(StatusNotImplemented), string(c.fasthttp.Response.Body()))
require.Equal(t, StatusNotImplemented, c.fasthttp.Response.StatusCode())
}

func Test_App_serverErrorHandler_Unsupported_Method_Request(t *testing.T) {
t.Parallel()

app := New()
app.Get("/bar", func(c Ctx) error {
return c.SendString("bar")
})

ln := fasthttputil.NewInmemoryListener()

serverStarted := make(chan struct{}, 1)
serverErr := make(chan error, 1)

go func() {
serverStarted <- struct{}{}
if err := app.Listener(ln); err != nil && !errors.Is(err, http.ErrServerClosed) {
serverErr <- err
return
}
serverErr <- nil
}()

<-serverStarted

conn, err := ln.Dial()
require.NoError(t, err)
require.NoError(t, conn.SetDeadline(time.Now().Add(5*time.Second)))

_, err = conn.Write([]byte("FOO /bar HTTP/1.1\r\nHost: example.com\r\n\r\n"))
require.NoError(t, err)

resp, err := http.ReadResponse(bufio.NewReader(conn), nil)
require.NoError(t, err)
require.Equal(t, StatusNotImplemented, resp.StatusCode)

body, err := io.ReadAll(resp.Body)
require.NoError(t, err)
require.Equal(t, utils.StatusMessage(StatusNotImplemented), string(body))
require.NoError(t, resp.Body.Close())
require.NoError(t, conn.Close())

require.NoError(t, app.Shutdown())
require.NoError(t, <-serverErr)
}

func Test_App_Nested_Params(t *testing.T) {
t.Parallel()
app := New()
Expand Down
Loading