Skip to content

fix: field selection set final values #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkoMin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: field selection set final values #1212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/Section 2 -- Language.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,8 @@ discrete piece of information available to request within a selection set.
Some fields describe complex data or relationships to other data. In order to
further explore this data, a field may itself contain a selection set, allowing
for deeply nested requests. All GraphQL operations must specify their selections
down to fields which return scalar values to ensure an unambiguously shaped
response.
down to fields which return scalar or enum values to ensure an unambiguously
shaped response.
Comment on lines +422 to +423
Copy link
Member

@benjie benjie Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
down to fields which return scalar or enum values to ensure an unambiguously
shaped response.
down to _leaf fields_ to ensure an unambiguously shaped response.

Paired with this, it would be good to change this to a definition:

graphql-spec/spec/Section 5 -- Validation.md

Lines 729 to 730 in ff0d285

A field subselection is not allowed on leaf fields. A leaf field is any field
with a scalar or enum unwrapped type. 

:: A field subselection is not allowed on leaf fields. A _leaf field_ is any
field with a scalar or enum unwrapped type.


For example, this operation selects fields of complex data and relationships
down to scalar values.
Expand Down