BE-419: Fix cargo publish failures for darwin-kperf crates#8471
BE-419: Fix cargo publish failures for darwin-kperf crates#8471indietyp wants to merge 6 commits into
cargo publish failures for darwin-kperf crates#8471Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
PR SummaryLow Risk Overview Workspace dependencies in the root All related crates (including Reviewed by Cursor Bugbot for commit e973eaa. Bugbot is set up for automated code reviews on this repo. Configure here. |
🤖 Augment PR SummarySummary: Standardizes darwin-kperf workspace dependency declarations by adding explicit versions alongside local paths to avoid 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8471 +/- ##
==========================================
- Coverage 59.13% 59.13% -0.01%
==========================================
Files 1346 1346
Lines 130077 130096 +19
Branches 5883 5883
==========================================
+ Hits 76923 76930 +7
- Misses 52248 52260 +12
Partials 906 906
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| darwin-kperf = { path = "libs/darwin-kperf", version = "0.1.1" } | ||
| darwin-kperf-criterion = { path = "libs/darwin-kperf/criterion", version = "0.1.1" } | ||
| darwin-kperf-events = { path = "libs/darwin-kperf/events", version = "0.1.1" } | ||
| darwin-kperf-sys = { path = "libs/darwin-kperf/sys", version = "0.1.1" } |
There was a problem hiding this comment.
These workspace dependency declarations specify version 0.1.1 for darwin-kperf packages, but when publishing to crates.io, the dependencies must be published before dependents. The CI pipeline needs to publish darwin-kperf-events and darwin-kperf-sys first (which have no dependencies), then darwin-kperf-criterion, and finally darwin-kperf.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| [dependencies] | ||
| # Public workspace dependencies | ||
| darwin-kperf-events = { version = "0.1.0", path = "../events", public = true } | ||
| darwin-kperf-events = { workspace = true, public = true } |
There was a problem hiding this comment.
This dependency specification causes publishing to fail because cargo tries to resolve darwin-kperf-events ^0.1.1 from crates.io during publish, but only 0.1.0 exists there. The publishing order needs to ensure darwin-kperf-events 0.1.1 is published first, or the dependency should be specified with an explicit version that exists on crates.io.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
|
What's the status of this? |
c57b1ad to
96d075f
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the darwin-kperf Rust workspace crates to publish cleanly by aligning crate versions and moving workspace dependency declarations to explicit { path, version } entries so workspace = true dependencies resolve with a publishable version.
Changes:
- Bumps
darwin-kperf*crate/package versions from0.1.0to0.1.1(includingCargo.lockupdates). - Updates root
Cargo.tomlworkspace dependencies to use full table syntax with explicitversion = "0.1.1". - Improves publish/readme behavior by adding
readme = "../README.md"to publishable crates and updating the README crate links; switchesdarwin-kperf-criteriontodarwin-kperf-events = { workspace = true }.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/darwin-kperf/sys/package.json | Bump JS package version to 0.1.1. |
| libs/darwin-kperf/sys/Cargo.toml | Bump crate version to 0.1.1; add shared README path. |
| libs/darwin-kperf/README.md | Update crate table formatting and link targets to crates.io. |
| libs/darwin-kperf/package.json | Bump JS package version to 0.1.1. |
| libs/darwin-kperf/events/package.json | Bump JS package version to 0.1.1. |
| libs/darwin-kperf/events/Cargo.toml | Bump crate version to 0.1.1; add shared README path. |
| libs/darwin-kperf/criterion/package.json | Bump JS package version to 0.1.1. |
| libs/darwin-kperf/criterion/Cargo.toml | Bump crate version; add shared README; use workspace-managed darwin-kperf-events dep. |
| libs/darwin-kperf/codegen/package.json | Bump private JS package version to 0.1.1-private. |
| libs/darwin-kperf/codegen/Cargo.toml | Bump internal codegen crate version to 0.1.1. |
| libs/darwin-kperf/Cargo.toml | Bump main crate version to 0.1.1. |
| Cargo.toml | Switch darwin-kperf* workspace deps to { path, version } entries (0.1.1). |
| Cargo.lock | Update locked versions for darwin-kperf* crates to 0.1.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I tabled this during my master's. The current issue is that publishing (dry-run) assumes that 0.1.1 has already been uploaded to the child crates, but they haven't. Leading to publishing CI to fail. Unsure how to solve this, any ideas? |
|
Hmm, I guess we need to publish them all at once? |
|
I guess so, I'll look at the CI step to see how one might achieve that in a way that is maintainable. |
Benchmark results
|
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| resolve_policies_for_actor | user: empty, selectivity: high, policies: 2002 | Flame Graph | |
| resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: empty, selectivity: medium, policies: 1001 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: high, policies: 3314 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: medium, policies: 1526 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: high, policies: 2078 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: medium, policies: 1033 | Flame Graph |
policy_resolution_medium
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| resolve_policies_for_actor | user: empty, selectivity: high, policies: 102 | Flame Graph | |
| resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: empty, selectivity: medium, policies: 51 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: high, policies: 269 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: medium, policies: 107 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: high, policies: 133 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: medium, policies: 63 | Flame Graph |
policy_resolution_none
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| resolve_policies_for_actor | user: empty, selectivity: high, policies: 2 | Flame Graph | |
| resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: empty, selectivity: medium, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: high, policies: 8 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: medium, policies: 3 | Flame Graph |
policy_resolution_small
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| resolve_policies_for_actor | user: empty, selectivity: high, policies: 52 | Flame Graph | |
| resolve_policies_for_actor | user: empty, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: empty, selectivity: medium, policies: 25 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: high, policies: 94 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: seeded, selectivity: medium, policies: 26 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: high, policies: 66 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: low, policies: 1 | Flame Graph | |
| resolve_policies_for_actor | user: system, selectivity: medium, policies: 29 | Flame Graph |
read_scaling_complete
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id;one_depth | 1 entities | Flame Graph | |
| entity_by_id;one_depth | 10 entities | Flame Graph | |
| entity_by_id;one_depth | 25 entities | Flame Graph | |
| entity_by_id;one_depth | 5 entities | Flame Graph | |
| entity_by_id;one_depth | 50 entities | Flame Graph | |
| entity_by_id;two_depth | 1 entities | Flame Graph | |
| entity_by_id;two_depth | 10 entities | Flame Graph | |
| entity_by_id;two_depth | 25 entities | Flame Graph | |
| entity_by_id;two_depth | 5 entities | Flame Graph | |
| entity_by_id;two_depth | 50 entities | Flame Graph | |
| entity_by_id;zero_depth | 1 entities | Flame Graph | |
| entity_by_id;zero_depth | 10 entities | Flame Graph | |
| entity_by_id;zero_depth | 25 entities | Flame Graph | |
| entity_by_id;zero_depth | 5 entities | Flame Graph | |
| entity_by_id;zero_depth | 50 entities | Flame Graph |
read_scaling_linkless
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 1 entities | Flame Graph | |
| entity_by_id | 10 entities | Flame Graph | |
| entity_by_id | 100 entities | Flame Graph | |
| entity_by_id | 1000 entities | Flame Graph | |
| entity_by_id | 10000 entities | Flame Graph |
representative_read_entity
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1
|
Flame Graph |
representative_read_entity_type
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| get_entity_type_by_id | Account ID: bf5a9ef5-dc3b-43cf-a291-6210c0321eba
|
Flame Graph |
representative_read_multiple_entities
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_property | traversal_paths=0 | 0 | |
| entity_by_property | traversal_paths=255 | 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true | |
| entity_by_property | traversal_paths=2 | 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false | |
| entity_by_property | traversal_paths=2 | 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true | |
| entity_by_property | traversal_paths=2 | 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true | |
| entity_by_property | traversal_paths=2 | 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true | |
| link_by_source_by_property | traversal_paths=0 | 0 | |
| link_by_source_by_property | traversal_paths=255 | 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true | |
| link_by_source_by_property | traversal_paths=2 | 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false | |
| link_by_source_by_property | traversal_paths=2 | 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true | |
| link_by_source_by_property | traversal_paths=2 | 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true | |
| link_by_source_by_property | traversal_paths=2 | 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true |
scenarios
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| full_test | query-limited | Flame Graph | |
| full_test | query-unlimited | Flame Graph | |
| linked_queries | query-limited | Flame Graph | |
| linked_queries | query-unlimited | Flame Graph |

🌟 What is the purpose of this PR?
This PR standardizes the dependency declarations for darwin-kperf workspace crates by migrating from path-only dependencies to workspace-managed dependencies with explicit versioning.
🔍 What does this change?
workspace = truefor its darwin-kperf-events dependency instead of explicit path and versionPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
❓ How to test this?
cargo checkto verify dependency resolution