Skip to content

fix(studio): keyframe stability + modular border-radius editor#1217

Open
miguel-heygen wants to merge 1 commit into
mainfrom
fix/keyframe-stability-border-radius
Open

fix(studio): keyframe stability + modular border-radius editor#1217
miguel-heygen wants to merge 1 commit into
mainfrom
fix/keyframe-stability-border-radius

Conversation

@miguel-heygen
Copy link
Copy Markdown
Collaborator

@miguel-heygen miguel-heygen commented Jun 5, 2026

Summary

  • Fix code editor not refreshing after GSAP script mutations (stale content until page refresh)
  • Fix keyframe cache not clearing on animation/keyframe deletion (orphaned timeline diamonds)
  • Fix pre-existing typecheck error (handleGsapMaterializeKeyframes optional in TimelineToolbar)
  • Add Figma-style visual border-radius editor with per-corner display and link/unlink toggle
  • Wire GSAP runtime-interpolated border-radius values to the corner picker

Test plan

  • Select element with GSAP animation, add keyframe via design panel diamond → code tab updates immediately
  • Delete keyframe via context menu → timeline diamond disappears without refresh
  • Delete all keyframes → Animation card resets, all diamonds gone
  • Select blob in 01-liquid-blob → Radius section shows per-corner values
  • Scrub playhead on GSAP-animated borderRadius element → corner values update in real-time
  • Toggle link/unlink in corner picker → uniform vs per-corner editing works

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Fallow audit report

Found 22 findings.

Duplication (11)
Severity Rule Location Description
minor fallow/code-duplication packages/studio/src/components/editor/MotionPanel.tsx:173 Code clone group 1 (18 lines, 2 instances)
minor fallow/code-duplication packages/studio/src/components/editor/PropertyPanel.tsx:259 Code clone group 1 (18 lines, 2 instances)
minor fallow/code-duplication packages/studio/src/contexts/DomEditContext.tsx:38 Code clone group 2 (40 lines, 3 instances)
minor fallow/code-duplication packages/studio/src/contexts/DomEditContext.tsx:107 Code clone group 2 (40 lines, 3 instances)
minor fallow/code-duplication packages/studio/src/contexts/FileManagerContext.tsx:54 Code clone group 3 (44 lines, 2 instances)
minor fallow/code-duplication packages/studio/src/hooks/useDomEditSession.ts:573 Code clone group 2 (40 lines, 3 instances)
minor fallow/code-duplication packages/studio/src/hooks/useFileManager.ts:87 Code clone group 4 (8 lines, 2 instances)
minor fallow/code-duplication packages/studio/src/hooks/useFileManager.ts:117 Code clone group 4 (8 lines, 2 instances)
minor fallow/code-duplication packages/studio/src/hooks/useFileManager.ts:296 Code clone group 5 (31 lines, 2 instances)
minor fallow/code-duplication packages/studio/src/hooks/useFileManager.ts:382 Code clone group 5 (31 lines, 2 instances)
minor fallow/code-duplication packages/studio/src/hooks/useFileManager.ts:450 Code clone group 3 (44 lines, 2 instances)
Health (11)
Severity Rule Location Description
major fallow/high-crap-score packages/studio/src/components/StudioHeader.tsx:143 'StudioHeader' has CRAP score 90.0 (threshold: 30.0, cyclomatic 9)
minor fallow/high-crap-score packages/studio/src/components/editor/PropertyPanel.tsx:128 'commitManualOffset' has CRAP score 31.6 (threshold: 30.0, cyclomatic 10)
critical fallow/high-crap-score packages/studio/src/components/editor/PropertyPanel.tsx:185 'gsapRuntimeValues' has CRAP score 106.4 (threshold: 30.0, cyclomatic 20)
minor fallow/high-crap-score packages/studio/src/components/editor/PropertyPanel.tsx:220 'gsapBorderRadius' has CRAP score 37.1 (threshold: 30.0, cyclomatic 11)
critical fallow/high-crap-score packages/studio/src/components/editor/propertyPanelStyleSections.tsx:38 'StyleSections' has CRAP score 62.5 (threshold: 30.0, cyclomatic 53)
major fallow/high-crap-score packages/studio/src/hooks/useFileManager.ts:69 '<arrow>' has CRAP score 56.0 (threshold: 30.0, cyclomatic 7)
major fallow/high-crap-score packages/studio/src/hooks/useFileManager.ts:194 'openSourceForSelection' has CRAP score 56.0 (threshold: 30.0, cyclomatic 7)
critical fallow/high-crap-score packages/studio/src/hooks/useFileManager.ts:237 'uploadProjectFiles' has CRAP score 182.0 (threshold: 30.0, cyclomatic 13)
major fallow/high-crap-score packages/studio/src/hooks/useGsapTweenCache.ts:123 'animations' has CRAP score 49.5 (threshold: 30.0, cyclomatic 13)
minor fallow/high-crap-score packages/studio/src/hooks/useGsapTweenCache.ts:225 '<arrow>' has CRAP score 31.6 (threshold: 30.0, cyclomatic 10)
minor fallow/high-crap-score packages/studio/src/hooks/useGsapTweenCache.ts:254 'tryRuntimeScan' has CRAP score 31.6 (threshold: 30.0, cyclomatic 10)

Generated by fallow.

@miguel-heygen Graphite App
Copy link
Copy Markdown
Collaborator Author

miguel-heygen commented Jun 6, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@miguel-heygen miguel-heygen mentioned this pull request Jun 6, 2026
Open
8 tasks
@miguel-heygen miguel-heygen force-pushed the fix/keyframe-stability-border-radius branch 2 times, most recently from 4d4133c to 40109f6 Compare June 6, 2026 21:28
@miguel-heygen miguel-heygen mentioned this pull request Jun 7, 2026
Open
7 tasks
@miguel-heygen miguel-heygen force-pushed the fix/keyframe-stability-border-radius branch from 40109f6 to 03339b8 Compare June 7, 2026 23:39
github-advanced-security[bot]
github-advanced-security AI found potential problems Jun 7, 2026
View reviewed changes
Comment thread packages/producer/src/services/render/stages/captureHdrResources.ts Fixed
Comment thread packages/producer/src/services/render/stages/captureHdrResources.ts Fixed
Comment thread packages/producer/src/services/renderOrchestrator.ts Fixed
@miguel-heygen miguel-heygen force-pushed the fix/keyframe-stability-border-radius branch from 03339b8 to 7bd6e17 Compare June 7, 2026 23:47
@miguel-heygen
fix(studio): keyframe stability + modular border-radius editor
5921c9f 
- Per-corner border-radius display and visual editor with corner picker
- Wire GSAP runtime border-radius values to corner picker
- Bump GSAP cache on code-tab edits
- Sync code editor after GSAP mutations + clear keyframe cache on deletion
- Flat undo/redo/capture buttons in header
@miguel-heygen miguel-heygen force-pushed the fix/keyframe-stability-border-radius branch from 7bd6e17 to 5921c9f Compare June 7, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miguel-heygen @github-advanced-security