Fix two performance bugs in walkDependencyTree#371
Open
YieldRay wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1 — No subtree memoization (O(N²) walk)
The existing
cacheobject only avoids re-reading files from disk. It does not prevent re-walking a subtree. When 70 app files all transitively importutils.ts, the subtree rooted atutils.tswas walked 70 times instead of once.Bug 2 — Recurses into
node_modulesprecinctextracts every import string from a file, including third-party ones ('react','clsx','@base-ui/react'). The walk was resolving and recursing into all of them. An island component that uses React + one UI library can pull in hundreds ofnode_modulesfiles, none of which can ever contain an island component.