fix(activesync): harden Autodiscover v2 (JSON) response handling#71
Merged
Merged
Conversation
Guard the unauthenticated Autodiscover v2 endpoint against clients that omit the required Protocol query parameter (defaulting to ActiveSync) instead of reading an undefined array index, and build the JSON body with json_encode() (JSON_UNESCAPED_SLASHES) rather than manual string concatenation. Add unit tests for the v2 JSON branch (happy path and missing Protocol).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protocolparameter (defaultActiveSync).json_encode()(JSON_UNESCAPED_SLASHES) instead of hand-rolled string concatenation.Motivation
The v2 handler read
getGetVars()['Protocol']directly, which raises an undefined-index warning when a client omits the parameter, and assembled the JSON response by hand (no escaping). Modern clients (recent iOS, Outlook) probe the v2 JSON endpoint first, so it should respond robustly.Changes
lib/Horde/ActiveSync/Request/Autodiscover.php: protocol guard +json_encode().test/unit/Horde/ActiveSync/AutodiscoverTest.php: two new tests (happy path + missing Protocol).Test plan
phpunit --filter Autodiscover-> 4 tests, 8 assertions, green