feat: add revokeToken() to OAuth2Client (RFC 7009)#4
Merged
Conversation
Member
|
Required for horde/base#109 |
ralflang
approved these changes
Jun 14, 2026
|
|
||
| $body = $this->streamFactory->createStream(http_build_query($params)); | ||
|
|
||
| $request = $this->requestFactory->createRequest('POST', $this->provider->revocationEndpoint) |
Member
There was a problem hiding this comment.
Not a bug but:
RFC 7009 §2.1 only says "the client also includes its authentication credentials" without prescribing the method, so this is spec-compliant.
Providers that advertise basic only on the revocation endpoint will reject the request.
Should we check tokenEndpointAuthMethodsSupported?
Author
There was a problem hiding this comment.
Good point, I should have reused the same logic as tokenRequest().
The revocation endpoint often shares the same auth method as the token
endpoint. I'll apply the same tokenEndpointAuthMethodsSupported check:
use HTTP Basic when client_secret_basic is advertised exclusively,
falling back to client_secret_post otherwise.
Member
|
Thank you for providing this! |
ralflang
pushed a commit
that referenced
this pull request
Jun 15, 2026
Follows up on #4. RFC 7009 §2.1 does not prescribe the client authentication method for the revocation endpoint. Providers that advertise client_secret_basic only will reject a request that sends credentials in the POST body. Apply the same tokenEndpointAuthMethodsSupported check as tokenRequest(): use HTTP Basic when client_secret_basic is advertised exclusively, fall back to client_secret_post otherwise. Adds two tests covering the Basic and mixed-methods cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements token revocation per RFC 7009 as a new
revokeToken()methodon
OAuth2Client.The method sends a POST to the provider's
revocation_endpointwith thetoken, its type hint, and the client credentials. If no revocation endpoint
is configured, it throws
OAuthException. HTTP 4xx responses from theprovider are also surfaced as
OAuthException.Intended to be used by OIDC pre-logout handlers to revoke access and
refresh tokens at the IdP before clearing the local session.
Includes unit tests covering: POST to correct endpoint, body contents,
default hint, absent client secret, missing endpoint, and error response.
@ralflang My OIDC login implementation is ready. This is PR 1 of 3 required to
continue the implementation.