Example#141
Draft
ocefpaf wants to merge 3 commits into
Draft
Conversation
ocefpaf
commented
Jun 15, 2026
| kept when subsetting the dataset | ||
| """ | ||
| if self._grid: | ||
| return self._grid.grid_vars(self._ds) |
Member
Author
There was a problem hiding this comment.
@MarianaVZorzo another way to fix this would be to make the return values here a set. However, I don't believe that is necessary or the intended design. That will become more clear as we fix more of the defined types. There is a good change that all we need are iterables.
PS: The ones right below and above this one could use the same fix. Feel free to implement them in #140 and knock 3 out of 50 warnings in that PR ;-p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. This is an example on how to solve the lints from #140.