Apply values from gradle.properties#30
Open
isXander wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring Modstitch properties through gradle.properties files instead of only through the Gradle build script DSL. Properties are searched deeply through the project hierarchy, allowing parent project properties to be inherited by child projects.
Key changes:
- Implements deep property searching through project tree hierarchy
- Adds property assignment utilities with null-safe operations
- Refactors extension initialization to apply properties before user configuration
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/dev/isxander/modstitch/util/ProjectUtils.kt | Adds utility functions for deep gradle property searching and null-safe property assignment |
| src/main/kotlin/dev/isxander/modstitch/base/BaseCommonImpl.kt | Implements property application logic and reorders initialization to apply properties before plugins |
| src/main/kotlin/dev/isxander/modstitch/base/loom/BaseLoomImpl.kt | Adds Fabric-specific property application for fabricLoaderVersion |
| src/main/kotlin/dev/isxander/modstitch/base/moddevgradle/BaseModDevGradleImpl.kt | Adds NeoForge/Forge-specific property application for version configurations |
| test-project/build.gradle.kts | Removes hardcoded configuration, demonstrating properties-based setup |
| test-project/gradle.properties | Adds modstitch properties for metadata and mixin configuration |
| test-project/fabric/gradle.properties | Converts platform-specific properties to modstitch namespace |
| test-project/forge/gradle.properties | Converts platform-specific properties to modstitch namespace |
| test-project/neoforge/gradle.properties | Converts platform-specific properties to modstitch namespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows you to configure all static modstitch properties from
gradle.properties.Closes #13
The property keys mirror that of the code path.
E.g.,
modstitch { minecraftVersion = "1.21.8" }could become
modstitch.minecraftVersion=1.21.8Modstitch searches for values deep within the project tree, meaning it will search through parents' properties too.
Extra considerations
Cousin problem
Modstitch is commonly used with tools like Stonecutter. In Stonecutter, the project structure looks like this.
This means the
1.21.8projects are cousins, not direct parent/child. This means that when configuring:extra:1.21.8,:core:1.21.8's gradle properties are not sourced, which makes sense.Controlify, my mod, does this exact thing, which would limit the usefulness of this PR, feedback is appreciated.
Bypass of intellisense
This makes errors a lot more tricky. If Modstitch had an update and changed/removed/renamed a property within its extension, there would be no highlighted error within the properties file, potentially leading to confusion, and tricky errors.