Skip to content

Fix type confusion bug #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacks0n9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type confusion bug #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions tables.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package tinydb

import "reflect"
import (
"encoding/json"
"reflect"
)

// Table the table of the database.
type Table[T any] struct {
Expand Down Expand Up @@ -83,17 +86,26 @@ func (tbl *Table[T]) Delete(condition func(T) bool) ([]T, error) {
func (tbl *Table[T]) Update(updater func(T) T, condition func(T) bool) error {
tbl.database.Lock()
defer tbl.database.Unlock()
var data = make(map[string][]T)
var data = make(map[string][]any)
err := tbl.database.storage.Read(&data)
if err != nil {
return err
}
var out []T
if _, ok := data[tbl.name]; !ok {
return nil
}
for i := range data[tbl.name] {
item := data[tbl.name][i]
raw, err := json.Marshal(data[tbl.name])
if err != nil {
return err
}
actualItems := []T{}
err = json.Unmarshal(raw, &actualItems)
if err != nil {
return err
}
var out []any

for _, item := range actualItems {
if condition(item) {
item = updater(item)
}
Expand Down