workflows/app.yml: Verify binaries that are built in CI run in CI too#4784
workflows/app.yml: Verify binaries that are built in CI run in CI too#4784illume wants to merge 6 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Adds a lightweight “verify built binaries run” smoke test for the Electron app across Linux/macOS/Windows, and wires it into CI so packaging regressions are caught early.
Changes:
- Introduces platform-specific build verification scripts under
app/scripts/(Linux/macOS shell scripts, Windows PowerShell). - Exposes those scripts via new
verify-build-*npm scripts (both atapp/level and repo root convenience wrappers). - Updates the GitHub Actions app workflow to run verification after packaging, and documents usage in developer docs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds root-level wrappers to run app build verification scripts from repo root. |
app/package.json |
Adds verify-build-{linux,mac,windows} scripts that invoke the new verifier scripts. |
app/scripts/verify-build-linux.sh |
Verifies Linux artifacts exist, extracts tarball, checks backend --version, runs list-plugins. |
app/scripts/verify-build-mac.sh |
Verifies DMG/app bundle, checks backend --version, runs list-plugins with a timeout tolerant of CI headless hangs. |
app/scripts/verify-build-windows.ps1 |
Verifies .exe installer, checks backend --version, runs Headlamp.exe list-plugins. |
.github/workflows/app.yml |
Runs the new verification steps after each platform build job. |
docs/development/index.md |
Documents the new verification commands and expected behavior (esp. macOS timeout note). |
app/README.md |
Documents the new app-level verification scripts and what they check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
For verify-build-linux, verify-build-mac, verify-build-windows.
6da37ad to
5b84062
Compare
|
Rebased against main to fix git conflict. |
Summary
Verifies the built app binaries run in CI (Mac, Linux, Windows).
Just basic checks for now, one artifact for each platform. Check the file is there, opens, runs backend, runs app.
Changes
Screenshots
In each app build CI job:
Mac
Windows
Linux
Steps to Test
Mainly the tests are useful in CI, to make sure we're generating binaries that run:
Manual testing.
npm run app:package(creates packaged artifacts inapp/dist/)npm run app:verify-build-linuxnpm run app:verify-build-windowsnpm run app:verify-build-mac[PASS]or✓markers