Reconcile Sync period modifications & ListVolume enhancements to support 120k CNS Volumes#3909
Open
chethanv28 wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… API in the wcp controller to look for volumeattachment status for Pod VM PVC & PV
25247c3 to
e204a90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The csi-attacher sidecar's VA reconciler runs on a default interval of 1 minute, calling ListVolumes on the CSI driver at every cycle. This flooded the CSI controller logs with noise at a rate of once per minute per cluster.
Additionally, the Supervisor (wcp) ListVolumes implementation accounted for Pod VM workloads, VM Service & VKS VM Service. Pod VMs are ephemeral VMs running inside supervisor namespaces whose disks do not appear in the standard ESXi host → VM hardware scan used to derive published nodes. As a result, PVCs consumed by Pod VMs were silently omitted from ListVolumes responses, giving the csi-attacher an incomplete view of volume-to-node mappings during its reconciliation cycles.
Testing done:
Running e2e pipelines. Results TBA
ListVolume invocation frequency is now reduced.
Before (invoked every minute):
After (invoked every 5 minutes):
Special notes for your reviewer:
Release note: