Open
Conversation
…is longer
When deep-diff places all insertions at the last index of the original
sequence, early deletions couldn't find their matching insertion because
replacements only checked positions d and d-1. Add a fallback that finds
the nearest insertion key > d, but only when all indices between d and
that key are also being deleted (no surviving elements in between).
This ensures correct positional pairing without false matches.
Example: (diff '({:a 1} {:b 1}) '({:a 2} {:b 2} {:c 2}))
Before (wrong):
[Deletion{:a 1} {Deletion{:b} 1, Insertion{:a} 2} Insertion{:b 2} Insertion{:c 2}]
After (correct):
[{:a Mismatch{1→2}} {:b Mismatch{1→2}} Insertion{:c 2}]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix replacements mispairing deletions and insertions when second seq is longer
When deep-diff places all insertions at the last index of the original
sequence, early deletions couldn't find their matching insertion because
replacements only checked positions d and d-1. Add a fallback that finds
the nearest insertion key > d, but only when all indices between d and
that key are also being deleted (no surviving elements in between).
This ensures correct positional pairing without false matches.
Example:
(diff '({:a 1} {:b 1}) '({:a 2} {:b 2} {:c 2}))Before (wrong):
[Deletion{:a 1} {Deletion{:b} 1, Insertion{:a} 2} Insertion{:b 2} Insertion{:c 2}]After (correct):
[{:a Mismatch{1→2}} {:b Mismatch{1→2}} Insertion{:c 2}]