add return to ctor parameters#92
Conversation
only in algebraic.d so far works around dip1000 compiler bug in general should rather fix issues than introduce new ones
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
=======================================
Coverage 38.68% 38.68%
=======================================
Files 12 12
Lines 473 473
=======================================
Hits 183 183
Misses 290 290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good. However, I would like to get approval from an additional Symmetry developer. @kinke, doesn't it need to be tested on the private codebase first? |
| Nullable!T nullable(T)(return T t) | ||
| { | ||
| import core.lifetime: forward; | ||
| return Nullable!T(forward!t); |
There was a problem hiding this comment.
Unrelated, I know, but forward doesn't really make sense here, for a non-auto ref param. It always boils down to a move for non-ref params.
|
@WebFreak001: You can test this in a SIL MR by changing the |
only added this in algebraic.d (since that's the module I care about and found the bug in)
works around dip1000 compiler bug
in general should rather fix issues than introduce new ones