Skip to content

add return to ctor parameters#92

Open
WebFreak001 wants to merge 1 commit into
libmir:masterfrom
WebFreak001:ctor-params-return
Open

add return to ctor parameters#92
WebFreak001 wants to merge 1 commit into
libmir:masterfrom
WebFreak001:ctor-params-return

Conversation

@WebFreak001

@WebFreak001 WebFreak001 commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

only added this in algebraic.d (since that's the module I care about and found the bug in)
works around dip1000 compiler bug
in general should rather fix issues than introduce new ones

only in algebraic.d so far
works around dip1000 compiler bug
in general should rather fix issues than introduce new ones
@codecov-commenter

codecov-commenter commented Nov 15, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.68%. Comparing base (69b98a4) to head (399008b).
⚠️ Report is 4 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   38.68%   38.68%           
=======================================
  Files          12       12           
  Lines         473      473           
=======================================
  Hits          183      183           
  Misses        290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@9il

9il commented Nov 15, 2023

Copy link
Copy Markdown
Member

Looks good. However, I would like to get approval from an additional Symmetry developer. @kinke, doesn't it need to be tested on the private codebase first?

Comment thread source/mir/algebraic.d
Nullable!T nullable(T)(return T t)
{
import core.lifetime: forward;
return Nullable!T(forward!t);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, I know, but forward doesn't really make sense here, for a non-auto ref param. It always boils down to a move for non-ref params.

@kinke

kinke commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

@WebFreak001: You can test this in a SIL MR by changing the mir-core selection in master.selections.json to a git+https selection to your branch here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants