Merged
Conversation
3ad8016 to
efe3c30
Compare
RomainCscn
reviewed
Mar 2, 2026
Collaborator
RomainCscn
left a comment
There was a problem hiding this comment.
Wondering if verbose and debug shouldn't be the same? Feels like having 3 log levels might be too much for this? Wdyt?
Collaborator
Author
|
I considered that at first, but opted to keep it separate since I think that debug sink and some debug data is borderline internal and there is a case to show quite some more info but still hide the proper debug information (hence the addition of verbose). Not a super strong opinion here, so happy to change if you feel that it is too much. |
Collaborator
|
Ok, no strong opinion either, I'm just trying to lean into simplicity when we can. |
RomainCscn
approved these changes
Mar 2, 2026
Collaborator
Author
|
Totally, also don't want to make it too complicated. Will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for log levels and migrates existing log calls to use these levels. There are three new options added to the CLI as arguments:
--quiet--verboseRelated PR for the GitHub action: linear/linear-release-action#10