fix: Update project state logic to correctly handle user roles and de…#5386
Open
hxrshxz wants to merge 2 commits intolitmuschaos:masterfrom
Open
fix: Update project state logic to correctly handle user roles and de…#5386hxrshxz wants to merge 2 commits intolitmuschaos:masterfrom
hxrshxz wants to merge 2 commits intolitmuschaos:masterfrom
Conversation
…activation Signed-off-by: Harsh <harshmastic@gmail.com>
3d3746b to
af7cdb2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where projects become invisible when a project owner is disabled, even if other active owners exist. The fix updates the UpdateProjectState method in the repository layer to add a filter that checks for other active owners before marking a project as removed.
Key Changes:
- Added a
$not+$elemMatchcondition to check if there are other active owners besides the user being deactivated - Modified the MongoDB filter to only mark projects as removed when the disabled user is the sole owner
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f3598f1 to
05f9099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixed issue where projects become invisible when a project owner is disabled, even if other active owners exist. Updated the
UpdateProjectStatemethod in the repository layer to only mark a project as removed when the disabled user is the only active owner.Link to issue: #5106
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Dependency
NA