fix(chaoscenter): fix backend url trailing slash issue #5393#5398
Open
SharanRP wants to merge 1 commit intolitmuschaos:masterfrom
Open
fix(chaoscenter): fix backend url trailing slash issue #5393#5398SharanRP wants to merge 1 commit intolitmuschaos:masterfrom
SharanRP wants to merge 1 commit intolitmuschaos:masterfrom
Conversation
Trims trailing slashes from CHAOS_CENTER_UI_ENDPOINT and host to prevent double slashes in the backend URL constructed for agents. Signed-off-by: SharanRP <z8903830@gmail.com>
|
@SharanRP some checks are not successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trims trailing slashes from CHAOS_CENTER_UI_ENDPOINT and host to prevent double slashes in the backend URL constructed for agents.
Proposed changes
This PR fixes an issue where the backend URL constructed for the litmus-agent would contain double slashes (e.g.,
https://host//api/query) if the configuredCHAOS_CENTER_UI_ENDPOINTor the host variable contained a trailing slash.Fix:
/api/query.Fixes #5393
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Dependency
N/A
Special notes for your reviewer:
Verified the fix locally by running unit tests against GetEndpoint with various URL patterns (with and without trailing slashes). The tests confirmed that the URL is now correctly normalized in all cases. The separate test file was not included in this PR to keep the changes minimal.