fix(auth): allow email addresses as usernames in Create User API#5418
Draft
DarkBird10020 wants to merge 3 commits intolitmuschaos:masterfrom
Draft
fix(auth): allow email addresses as usernames in Create User API#5418DarkBird10020 wants to merge 3 commits intolitmuschaos:masterfrom
DarkBird10020 wants to merge 3 commits intolitmuschaos:masterfrom
Conversation
Contributor
|
@DarkBird10020 can you please confirm what happens when an user has created a account using dex and then used the same email as username to create another account this time without dex. |
Contributor
|
@DarkBird10020 any updates?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes Issue #5413 where the Create User API rejects email-based usernames due to the strict 3–16 character / alphanumeric-only validation. Since Dex login uses the user’s email as
username, pre-creating users via API with their email was not possible.What changed
ValidateStrictUsernameto accept email addresses as valid usernames (up to 255 chars) while preserving the existing strict rules for non-email usernames.john.smith.long@example.com) so Dex login can match the pre-created account.Why this is safe
Files changed
chaoscenter/authentication/pkg/utils/sanitizers.goTest plan
username = john.smith.long@example.com→ should succeeduser@) → should failtest_user) → should still succeedType of change