Fix the product gallery tab when an image attribute label contains a single quote

[blmage]

Description (*)

The data-types attribute in the admin product gallery is delimited using single quotes with @noEscape. When an image attribute label contains a single quote (e.g. Image d'exemple), the attribute is cut off and the gallery breaks.

Fix: use escapeHtmlAttr() with double quotes, consistent with data-images on the line above.

Introduced in 17f0f4d (MAGETWO-99285), where escapeHtml() was replaced with @noEscape instead of escapeHtmlAttr().

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Images and Videos tab not working #16807

Manual testing scenarios (*)

1. Create an image attribute with a label containing a single quote (e.g. Image d'exemple)
2. Assign it to some attribute set
3. Edit any corresponding product in the admin and open the gallery tab: the gallery is broken

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix the product gallery tab when an image attribute label contains a single quote #40519: Fix the product gallery tab when an image attribute label contains a single quote

[m2-assistant]

Hi @blmage. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Bravo]

@magento create issue