Skip to content

Use category repository to take advantage of the memory cache#40532

Open
alinalexandru wants to merge 1 commit intomagento:2.4-developfrom
innobyte:fix/40472-remove-duplicate-queries
Open

Use category repository to take advantage of the memory cache#40532
alinalexandru wants to merge 1 commit intomagento:2.4-developfrom
innobyte:fix/40472-remove-duplicate-queries

Conversation

@alinalexandru
Copy link
Member

Description (*)

This pull request enhances the Category data provider in Magento's catalog module by introducing support for using the CategoryRepositoryInterface to retrieve category data, which enables better caching and consistency across the application. It also adds comprehensive unit and integration tests to verify this new behavior and ensure proper fallback logic.

This behaviour is since the beginning of magento2, and it's probably a ported solution from magento1.
In the next major release, usage of CategoryModel can be removed, as it's deprecated.

Screen shot of improvement:
Screenshot 2026-02-14 at 12 00 20

Queries removed:
Screenshot 2026-02-14 at 12 00 58

It's not a big improvement, but it's a free one.
It’s true that getCategory has become a bit more complex and potentially harder to follow due to the additional dependency. However, my goal was to keep the change as minimal and contained as possible.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Loading category from database twice on a category Page #40472

Manual testing scenarios (*)

  1. Deploy magento 2.4 with sample data
  2. Profile the page gear/bags.html and check how many queries are executed
  3. Deploy current branch with sample data
  4. Profile the page gear/bags.html and check how many queries are executed
  5. The page should be loaded correctly
  6. Compare the results

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 14, 2026

Hi @alinalexandru. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@alinalexandru
Copy link
Member Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 17, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Feb 17, 2026
@alinalexandru
Copy link
Member Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Loading category from database twice on a category Page

2 participants