Use category repository to take advantage of the memory cache#40532
Open
alinalexandru wants to merge 1 commit intomagento:2.4-developfrom
Open
Use category repository to take advantage of the memory cache#40532alinalexandru wants to merge 1 commit intomagento:2.4-developfrom
alinalexandru wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @alinalexandru. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Member
Author
|
@magento run all tests |
Member
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
This pull request enhances the
Categorydata provider in Magento's catalog module by introducing support for using theCategoryRepositoryInterfaceto retrieve category data, which enables better caching and consistency across the application. It also adds comprehensive unit and integration tests to verify this new behavior and ensure proper fallback logic.This behaviour is since the beginning of magento2, and it's probably a ported solution from magento1.
In the next major release, usage of CategoryModel can be removed, as it's deprecated.
Screen shot of improvement:

Queries removed:

It's not a big improvement, but it's a free one.
It’s true that
getCategoryhas become a bit more complex and potentially harder to follow due to the additional dependency. However, my goal was to keep the change as minimal and contained as possible.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)