fix(config): capture config value before beforeSave() transforms it for lock-env#40541
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
Conversation
…or lock-env When using `bin/magento config:set --lock-env`, the LockProcessor was capturing the value AFTER calling beforeSave() on the backend model. Some backend models transform the value in beforeSave() for database serialization (e.g. converting a comma-separated string to an array). This caused the DB-serialized form (e.g. an array) to be written to env.php, making subsequent reads from env.php return the wrong type and causing errors like: explode(): Argument magento#2 ($string) must be of type string, array given Fixed by capturing the value before beforeSave() is called, so env.php receives the scalar value rather than the DB-serialized form. Fixes magento#39836
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
When using
bin/magento config:set --lock-env, theLockProcessorwas capturing the configuration value after callingbeforeSave()on the backend model. Some backend models transform the value inbeforeSave()for database serialization (e.g. converting a comma-separated string to an array). This caused the DB-serialized form (e.g. an array) to be written toenv.php, making subsequent reads return the wrong type.Example error:
Root cause: After
bin/magento config:set --lock-env twofactorauth/general/force_providers google,env.phpincorrectly stored['google'](array) instead of'google'(string) becauseForceProviders::beforeSave()transforms the value for database storage.Fix: Capture the value before
beforeSave()is called. ThebeforeSave()lifecycle hook is intended for database serialization and should not affect what is stored inenv.php. ThevalidateBeforeSave()call remains first to still run all validations.Related Pull Requests
No related pull requests
Fixed Issues
Fixes #39836
Manual testing scenarios (*)
bin/magento config:set --lock-env twofactorauth/general/force_providers googleenv.phpcontains'force_providers' => 'google'(string, not array)bin/magentoand confirm no errors aboutexplode()receiving array instead of stringQuestions or comments
No questions or comments
Contribution checklist (*)
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz