fix(import): handle zero values for stock use_config fields during product import#40542
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
Conversation
…port The _setStockUseConfigFieldsValues() method used !empty($value) to check if a stock field had been explicitly set in the import CSV. However, !empty(0) returns false in PHP, causing fields with a valid value of 0 (e.g. backorders = 0 meaning "No Backorders") to be ignored. As a result, use_config_backorders was never set to 0, so the product continued to use the system configuration default even when the CSV explicitly specified a different value. Changed !empty($value) to $value !== null && $value !== '' to correctly treat numeric 0 as a valid explicit value while still skipping truly empty entries (null or empty string). Fixes magento#39780
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
The
_setStockUseConfigFieldsValues()method in the product import used!empty($value)to check if a stock field had been explicitly set in the import CSV. However,!empty(0)returnsfalsein PHP, causing fields with a valid value of0(e.g.allow_backorders = 0meaning "No Backorders") to be ignored.As a result,
use_config_backorderswas never set to0, so the imported product continued to use the system configuration default even when the CSV explicitly specifiedallow_backorders = 0. The same bug affects other stock fields that can have0as a valid value.Fix: Changed
!empty($value)to$value !== null && $value !== ''to correctly treat numeric0as a valid explicit value while still skipping truly empty entries (null or empty string).Related Pull Requests
No related pull requests
Fixed Issues
Fixes #39780
Manual testing scenarios (*)
allow_backorders = 0(No Backorders) for a productQuestions or comments
No questions or comments
Contribution checklist (*)
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz