ci(go): enforce gofmt -l in PR pipeline#200
Merged
Merged
Conversation
Mirrors the gofmt -l check already gating publish-go.yml. Without this in CI, formatting drift only surfaces when a release tag is pushed (caught the 0.3.0 release). Re-formats the two files that had drifted since the last gofmt pass: ahp/client_test.go and examples/reducers_demo/main.go (struct-field alignment only, no semantic change).
Captures the operational counterpart to RELEASING.md: two-commit PR structure, the six tag schemes, merge-vs-squash gotcha for tag SHA preservation, GPG/pubring-lock recovery, and the delete+re-push recovery for tags whose publish workflow didn't fire.
roblourens
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
gofmt -lenforcement step to the Go CI job so formatting drift surfaces in PRs instead of only at release-tag time.Context
The Go 0.3.0 publish workflow (
publish-go.yml) failed during the AHP 0.3.0 release because two committed Go files had drifted out ofgofmtshape:clients/go/ahp/client_test.goclients/go/examples/reducers_demo/main.goThe
publish-go.ymlworkflow already runsgofmt -las a tag-time gate, but nothing equivalent ran inci.yml, so the drift was invisible until a release tag was pushed.Commits
ci(go): enforce gofmt -l in PR pipeline— adds aCheck Go formattingstep to thegojob in.github/workflows/ci.yml, mirroring the existing check inpublish-go.yml. Re-formats the two drifted files (struct-field alignment only, no semantic change) so this PR is itself green.docs: add release-ahp skill— adds.github/skills/release-ahp/SKILL.mdcapturing the multi-artifact release flow (two-commit PR, six tag schemes, merge-vs-squash gotcha, GPG/pubring-lock recovery, and the delete+re-push recovery for tags whose publish workflow doesn't fire — which is exactly what bit us on the 0.3.0 release).Both Go
build,vet, andgofmt -lpass cleanly locally on the resulting tree.