Skip to content

SFI: enable C# CodeQL coverage #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haoliuu merged 7 commits into from
Jun 4, 2026
+18 −1
Merged

SFI: enable C# CodeQL coverage #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9bdd50f
SFI: enable CodeQL in CI
haoliuu Jun 3, 2026
f7b8ce9
SFI: disable EmitCompilerGeneratedFiles to fix CS0016 under CodeQL3000
haoliuu Jun 3, 2026
f6e88b5
SFI: explicitly invoke CodeQL3000 Init/Finalize around build to emit …
haoliuu Jun 3, 2026
8b51853
SFI: pin EmitCompilerGeneratedFiles=false via TreatAsLocalProperty so…
haoliuu Jun 3, 2026
29a31aa
SFI: disable 1ESPT compiled auto-injection (explicit CodeQL Init/Fina…
haoliuu Jun 3, 2026
df33972
SFI: mirror CodeQL config in release.yml (explicit Init/Finalize owns…
haoliuu Jun 3, 2026
06c1929
SFI: address PR review (Finalize condition: always(), document EmitCo…
haoliuu Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .pipelines/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ extends:
name: Azure-Pipelines-1ESPT-ExDShared
image: windows-latest
os: windows
codeql:
compiled:
enabled: false
buildIdentifier: 'Build_$(System.JobAttempt)'
runSourceLanguagesInSourceAnalysis: true
stages:
- stage: Build
jobs:
Expand Down
5 changes: 5 additions & 0 deletions .pipelines/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ extends:
name: Azure-Pipelines-1ESPT-ExDShared
image: windows-latest
os: windows
codeql:
compiled:
enabled: false
buildIdentifier: 'Build_$(System.JobAttempt)'
runSourceLanguagesInSourceAnalysis: true
stages:
- stage: Build
jobs:
Expand Down
5 changes: 5 additions & 0 deletions .pipelines/templates/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,15 @@ steps:
displayName: Update Package Manifest Version
- script: dotnet restore AIDevGallery.sln -r win-${{ parameters.dotnet_platform }} /p:Configuration=${{ parameters.dotnet_configuration }} /p:Platform=${{ parameters.dotnet_platform }} /p:PublishReadyToRun=true /p:SelfContainedIfPreviewWASDK=true
displayName: Restore dependencies - ${{ parameters.dotnet_platform }}
- task: CodeQL3000Init@0
displayName: 'CodeQL Initialize'
- script: |
dotnet build AIDevGallery.Utils --no-restore /p:Configuration=Release
dotnet build AIDevGallery --no-restore -r win-${{ parameters.dotnet_platform }} -f net9.0-windows10.0.26100.0 /p:Configuration=${{ parameters.dotnet_configuration }} /p:Platform=${{ parameters.dotnet_platform }} /p:AppxPackageDir="AppPackages/" /p:UapAppxPackageBuildMode=SideloadOnly /p:AppxBundle=Never /p:GenerateAppxPackageOnBuild=true /p:SelfContainedIfPreviewWASDK=true /p:LafPublisherId=$(LAF_PUBLISHER_ID) /p:LafToken=$(LAF_TOKEN)
displayName: Build - ${{ parameters.dotnet_platform }}
- task: CodeQL3000Finalize@0
displayName: 'CodeQL Finalize'
Comment thread
haoliuu marked this conversation as resolved.
condition: always()
- ${{ if eq(parameters.publishSymbols, true) }}:
- task: PublishSymbols@2
displayName: Publish Symbols - ${{ parameters.dotnet_platform }}
Expand Down
4 changes: 3 additions & 1 deletion AIDevGallery/AIDevGallery.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk" TreatAsLocalProperty="EmitCompilerGeneratedFiles">
<PropertyGroup>
<OutputType>WinExe</OutputType>
Comment thread
haoliuu marked this conversation as resolved.
<TargetFramework>net9.0-windows10.0.26100.0</TargetFramework>
Expand All @@ -20,6 +20,8 @@
<!-- TODO: Fix IDisposableAnalyzers warnings from Microsoft.AI.Foundry.Local.WinML transitive dependency in next PR -->
<NoWarn>$(NoWarn);IDISP001;IDISP002;IDISP003;IDISP004;IDISP006;IDISP007;IDISP008;IDISP017;IDISP025</NoWarn>
<IsAotCompatible>true</IsAotCompatible>
<!-- Pinned via TreatAsLocalProperty on <Project> so the CodeQL tracer can't override it; enabling it causes CS0016 build failures with WinRTAotSourceGenerator. -->
<EmitCompilerGeneratedFiles>false</EmitCompilerGeneratedFiles>
<TrimmerRootDescriptor>SamplesRoots.xml</TrimmerRootDescriptor>
<!-- The *first* DefineConstants is removed during Official Release Builds (.pipelines/Unstub.ps1)-->
<DefineConstants>TELEMETRYEVENTSOURCE_PUBLIC</DefineConstants>
Expand Down
Loading