Open
Conversation
Contributor
|
@femiatl Could you please resolve the conflicts such that CI can work on this PR. |
54e3a52 to
d4626b2
Compare
Contributor
|
It seems that this change is based on new ABI to simplify data transfer. Good idea! As @tgopinath-microsoft noted in #652, this cannot be merged yet. One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get |
sangho2
reviewed
Feb 13, 2026
sangho2
reviewed
Feb 13, 2026
3a4f589 to
73eb949
Compare
VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.
- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing
73eb949 to
c7c723c
Compare
Latest modular_bitfield generates warnings
|
🤖 SemverChecks 🤖 Click for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.
The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.
The validate_module and validate_kexec APIs are extended to use the new attributes.