Open
Conversation
Member
Author
|
Note: the sha256 change shifts one bottleneck to further along the pipeline for the particular environment I am running this in, but I will leave those changes to a separate PR when I get some more cycles. |
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
wdcui
approved these changes
Feb 26, 2026
Member
wdcui
left a comment
wdcui
left a comment
There was a problem hiding this comment.
LGTM. I left one comment below.
| .duration_since(std::time::UNIX_EPOCH) | ||
| .unwrap_or_default(); | ||
| let size = metadata.len(); | ||
| Ok(format!("{}:{}", mtime.as_nanos(), size)) |
Member
There was a problem hiding this comment.
We don't want to include the file path in the summary?
Member
Author
There was a problem hiding this comment.
Good point, does not really hurt to include the file path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two somewhat related changes I hit when running the Python test. Some versions of Python (concretely, 3.12.1) require more files to be pulled in than were being pulled in before; the first commit in this PR fixes this. The second commit speeds the cache up by just using mtime+size rather than spending a bunch of time on computing sha256.