Revert "smoke: wait for copilot-chat extension before writing its settings"

[alexdima]

Reverts #320255

[Copilot]

Pull request overview

This PR reverts a prior smoke-test change that waited for the GitHub.copilot-chat extension to be installed/activated before writing Copilot Chat-related settings, restoring the previous behavior in the smoke test extension host helper.

Changes:

• Removed the waitForExtension(...) helper that polled for GitHub.copilot-chat and activated it.
• Removed the pre-settings-write wait in smoketest.openCopilotCliChat and smoketest.openClaudeChat.

Show a summary per file

File	Description
test/smoke/extensions/vscode-smoketest-ext-host/extension.js	Removes the Copilot Chat “wait for extension before writing settings” logic from smoke-test helper commands.

Copilot's findings

Comments suppressed due to low confidence (2)

test/smoke/extensions/vscode-smoketest-ext-host/extension.js:100

• These configuration updates can throw if the Copilot Chat extension hasn’t finished registering its contributed settings yet (workspace configuration update throws for unregistered keys). The reverted waitForExtension(...) avoided this race; without any wait before update(...), smoke runs can fail intermittently right after installing the extension. Consider waiting for a Copilot Chat-contributed command to be registered (which implies the extension has been scanned and its configuration schema is registered) before calling update(...).

			const command = 'workbench.action.chat.openNewSessionEditor.copilotcli';
			await vscode.workspace.getConfiguration('chat').update('disableAIFeatures', false, vscode.ConfigurationTarget.Global);
			await vscode.workspace.getConfiguration('github.copilot.chat').update('backgroundAgent.enabled', true, vscode.ConfigurationTarget.Global);
			await vscode.commands.executeCommand('github.copilot.debug.extensionState');
			await waitForCommand(command, 60_000);

test/smoke/extensions/vscode-smoketest-ext-host/extension.js:112

• Same as above: getConfiguration('github.copilot.chat').update(...) can throw if Copilot Chat hasn’t registered its configuration yet. Adding a short wait for a Copilot Chat-contributed command before updating settings avoids intermittent smoke failures when the extension is installed on-demand.

			const command = 'workbench.action.chat.openNewSessionEditor.claude-code';
			await vscode.workspace.getConfiguration('chat').update('disableAIFeatures', false, vscode.ConfigurationTarget.Global);
			await vscode.workspace.getConfiguration('github.copilot.chat').update('claudeAgent.enabled', true, vscode.ConfigurationTarget.Global);
			await vscode.commands.executeCommand('github.copilot.debug.extensionState');
			await waitForCommand(command, 60_000);

• Files reviewed: 1/1 changed files
• Comments generated: 0