fix(docs): ship import map in prod and remove dead theme toggle#389
Merged
Conversation
The fiddles' import map was injected by reading src/generated/modules.json via
fs.readFileSync at render time. Next's file tracing doesn't follow that
computed path, so the file is dropped from the production server bundle, the
read throws, and the import map silently disappears - breaking every fiddle's
runtime import('@revideo/2d') with 'bare specifier ... not remapped'. Import
the manifest statically so Next bundles it in.
Also hide Nextra's sidebar theme switch (darkMode={false}): the docs are
hard-forced to dark, so the toggle did nothing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fiddles' import map was injected by reading src/generated/modules.json via fs.readFileSync at render time. Next's file tracing doesn't follow that computed path, so the file is dropped from the production server bundle, the read throws, and the import map silently disappears - breaking every fiddle's runtime import('@revideo/2d') with 'bare specifier ... not remapped'. Import the manifest statically so Next bundles it in.
Also hide Nextra's sidebar theme switch (darkMode={false}): the docs are hard-forced to dark, so the toggle did nothing.