Skip to content

fix(test): merge project-level use into config for actionTimeout and other options#220

Open
sarang-code2 wants to merge 1 commit into
mobile-next:mainfrom
sarang-code2:fix/config-scope
Open

fix(test): merge project-level use into config for actionTimeout and other options#220
sarang-code2 wants to merge 1 commit into
mobile-next:mainfrom
sarang-code2:fix/config-scope

Conversation

@sarang-code2

Copy link
Copy Markdown

The device fixture only reads top-level config.use, silently ignoring options set inside config.projects[].use like actionTimeout, appLaunchTimeout, installTimeout, and animations.

Finds the matching project by name via testInfo.project.name and merges its use into the top-level use before passing to connectDevice.

…other options

The device fixture only read top-level config.use, silently ignoring
options set inside config.projects[].use like actionTimeout,
appLaunchTimeout, installTimeout, and animations.

Now finds the matching project by name from testInfo.project.name and
merges its use into the top-level use before passing to connectDevice.
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e16c2255-dcd7-4289-8042-370dd1b159bd

📥 Commits

Reviewing files that changed from the base of the PR and between bfac05a and 0ec4c07.

📒 Files selected for processing (1)
  • packages/test/src/fixtures.ts

Walkthrough

The device fixture in packages/test/src/fixtures.ts was updated to derive per-project use configuration. It now locates the current Playwright project from config.projects and merges that project's use overrides with the global config.use, producing a projectUse object that is explicitly set on the merged fixture config. Previously, the merged config relied only on the global config.use without incorporating project-specific overrides.

Changes

Area Change
packages/test/src/fixtures.ts device fixture now merges project-level use overrides with global config use

Related issues: None provided.

Related PRs: None provided.

Suggested labels: bug, test

Suggested reviewers: None provided.

🐰 A fixture hopped and found a way,
To merge each project's use today,
No longer stuck on global rules alone,
Per-project settings now are shown,
A tiny patch, a tidy gain, hooray!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: merging project-level use settings into config for test device options.
Description check ✅ Passed The description matches the change and explains why project-level use is now merged for device connection options.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant