fix: no re-emit unhandledRejection for non-Mocha registred listener #5987
Open
mostafaNazari702 wants to merge 1 commit into
Open
fix: no re-emit unhandledRejection for non-Mocha registred listener #5987mostafaNazari702 wants to merge 1 commit into
mostafaNazari702 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5987 +/- ##
==========================================
- Coverage 80.89% 80.89% -0.01%
==========================================
Files 64 64
Lines 4602 4607 +5
Branches 976 976
==========================================
+ Hits 3723 3727 +4
- Misses 879 880 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Added only a space in the end of the PR title to re-run tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Current unhandledRejection handler used to remove itself and re-emit the event so node could apply its default behavior but this made user listeners to run twice when present.
this change skips the re-emit if any other unhandledRejection listener is registered thus preventing duplicates and in the same time keeping the existing no-listener behavior unchanged.
An integration test ensures user listeners are called exactly once.