Complete SOW-0050 and SOW-0058 backend gate hardening#61
Merged
Conversation
Finish the first backend residual-complexity slice, harden benchmark gate stability, refresh the workstation baseline, record review convergence, and close both SOW ledgers after full gate validation.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 140 |
| Duplication | 26 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
1 issue found across 23 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
Resolve PR check findings in ingest tests and benchmark gate shell assertions; record remediation validation.
Capture failed benchmark command status before reporting and track remaining ingest test complexity debt.
Member
Author
|
Addressed the benchmark failure-diagnostic finding by capturing the failed benchmark command status inside the failing branch and tightening the benchmark self-test to require the fake go test exit code. Added SOW-0059 to track the remaining pre-existing ingest test complexity inventory and documented the Codacy/Lizard count split. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
timeout 3600 ./scripts/gates.shpassed after PR check remediation in 1581s.Tail_SyntheticAppendmeasurement noise at +20.06%sec/op; attempt 2 did not reproduce that same benchmark-name regression, so the benchmark gate passed by its retry contract.-race.bash -n scripts/check-bench.sh scripts/test/check-bench-test.sh, ShellCheck, and the benchmark self-test passed.internal/*aggregate 91.0%.PRODUCTION GRADE: YESon the final staged diff.