physics: bind issue 1228 slice 3 unit carriers#1359
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c09ac5c777
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| falsifier: | ||
| command: >- | ||
| bash -c 'python -m json.tool artifacts/physics_validation/issue_1228_slice3_unit_contract_verdict.json >/dev/null && grep -q "dt" docs/physics/units_table.md' |
There was a problem hiding this comment.
P2 valid: exact carrier check required
The generic grep -q "dt" remains too weak because docs/physics/units_table.md contains other dt occurrences. Do not resolve this until .claude/commit_acceptors/issue-1228-slice3-unit.yaml itself checks:
grep -F -q '| `dt` |' docs/physics/units_table.mdThere was a problem hiding this comment.
Fixed in 4f49403387690f5e5c86fb765c00114edd5325c1.
The acceptor no longer uses generic grep -q "dt". It now constructs and checks the exact row carrier string via Python, so unrelated dt occurrences cannot satisfy the falsifier.
Also narrowed scripts/ci/prove_repo_integrity.sh back to the original structure with only the intended invariant witness update 112 -> 132.
ac54f57 to
af1ac2a
Compare
What
Closes the highest-priority unit-contract carrier debt left open after #1353.
Binds issue #1228 tasks 18–22 to durable carriers and repairs the stale repository-integrity invariant witness count.
Scope
dtrow indocs/physics/units_table.md.artifacts/physics_validation/.scripts/ci/prove_repo_integrity.shnow expects the current invariant count132instead of stale112..claude/commit_acceptors/binds every changed file.Tracking issue: #1356.
Non-claims
81.5.Verification