Skip to content

physics: bind issue 1228 slice 3 unit carriers#1359

Merged
neuron7xLab merged 7 commits into
mainfrom
nfi-units-slice3
Jun 26, 2026
Merged

physics: bind issue 1228 slice 3 unit carriers#1359
neuron7xLab merged 7 commits into
mainfrom
nfi-units-slice3

Conversation

@neuron7xLab

@neuron7xLab neuron7xLab commented Jun 25, 2026

Copy link
Copy Markdown
Owner

What

Closes the highest-priority unit-contract carrier debt left open after #1353.

Binds issue #1228 tasks 18–22 to durable carriers and repairs the stale repository-integrity invariant witness count.

Scope

  • Task 18: explicit dt row in docs/physics/units_table.md.
  • Task 19: artifact-only unit verdict under artifacts/physics_validation/.
  • Task 20: unit smoke-test carrier link.
  • Task 21: dimensional homogeneity test link.
  • Task 22: pass/fail summary field in the artifact verdict.
  • CI debt: scripts/ci/prove_repo_integrity.sh now expects the current invariant count 132 instead of stale 112.
  • Commit acceptor under .claude/commit_acceptors/ binds every changed file.

Tracking issue: #1356.

Non-claims

  • Score remains 81.5.
  • No target interval claim.
  • No final physics validation claim.
  • Static unit labels remain bookkeeping contracts, not promoted physics-invariant witnesses.

Verification

python -m json.tool artifacts/physics_validation/issue_1228_slice3_unit_contract_verdict.json
grep -q '| `dt` |' docs/physics/units_table.md
grep -q "132" scripts/ci/prove_repo_integrity.sh
python -m pytest tests/physics/test_dimensional_homogeneity.py -q
python scripts/ci/check_acceptor_command_syntax.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c09ac5c777

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


falsifier:
command: >-
bash -c 'python -m json.tool artifacts/physics_validation/issue_1228_slice3_unit_contract_verdict.json >/dev/null && grep -q "dt" docs/physics/units_table.md'

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 valid: exact carrier check required

The generic grep -q "dt" remains too weak because docs/physics/units_table.md contains other dt occurrences. Do not resolve this until .claude/commit_acceptors/issue-1228-slice3-unit.yaml itself checks:

grep -F -q '| `dt` |' docs/physics/units_table.md

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 4f49403387690f5e5c86fb765c00114edd5325c1.

The acceptor no longer uses generic grep -q "dt". It now constructs and checks the exact row carrier string via Python, so unrelated dt occurrences cannot satisfy the falsifier.

Also narrowed scripts/ci/prove_repo_integrity.sh back to the original structure with only the intended invariant witness update 112 -> 132.

@neuron7xLab neuron7xLab merged commit bdc9a34 into main Jun 26, 2026
29 checks passed
@neuron7xLab neuron7xLab deleted the nfi-units-slice3 branch June 26, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant