Draft
Conversation
…fixedMagWindow
…fixedMagWindow
… into fixedMagWindow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#19462
Summary of the issue:
Phase 2 of Magnifier requier more types than Fullscreen, this Pr will concentrate on Fixed Window
Description of user facing changes:
Users will be able to switch from Fullscreen to Fixed magnifier.
Description of developer facing changes:
Description of development approach:
Fixed/Docked/Lens should be using the same logic so getting one down should open a good path for the others. Focusing on one seems the best wait to implement them.
Testing strategy:
Known issues with pull request:
Code Review Checklist: