[DO NOT MERGE] attribute: add BYTES type support#7948
[DO NOT MERGE] attribute: add BYTES type support#7948NesterovYehor wants to merge 7 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7948 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 304 304
Lines 23287 23325 +38
=====================================
+ Hits 19039 19074 +35
- Misses 3862 3865 +3
Partials 386 386
🚀 New features to boost your workflow:
|
pellared
left a comment
There was a problem hiding this comment.
Overall LGTM. I left a few comments.
Please also add the benchmark results for ``BenchmarkBytes` in the PR description.
87ff3a1 to
95b2ce9
Compare
|
We would also need to comply with SDK attribute value limits https://opentelemetry.io/docs/specs/otel/common/#anyvalue
I propose to do this in a separate PR and also track it in a separate issue. The important thing is that both PRs would need to be shipped in the same release. If you want you can already start working it in a separate branch / draft PR EDIT: I created #7954 |
Caution
This should not be merged before we have a v1.41.0 release.
Fixes #7933
Add BYTES type to https://pkg.go.dev/go.opentelemetry.io/otel/attribute