Restore one-sided return_input options in overlap#240
Open
OfficialBishal wants to merge 1 commit into
Open
Conversation
overlap() historically accepted 1/"1"/"left" and 2/"2"/"right" to return only one side's columns, but a refactor reduced return_input to a plain truthiness check, so every non-False value returned both sides. Restore the documented values, raise ValueError on unsupported input, and add tests. Closes open2c#197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197.
overlap(..., return_input=...)used to accept1/"1"/"left"to return only df1's columns and2/"2"/"right"to return only df2's, but a refactor reducedreturn_inputto a plain truthiness check, so any non-Falsevalue silently returned both sides. This restores the documented options and makes unsupported values raise instead of failing silently.Changes:
overlapresolvesreturn_inputinto left/right flags and raisesValueErrorfor values outside{True, False, 1, 2, "1", "2", "left", "right"}.test_overlap_return_inputcovering both / neither / left-only / right-only and the error case.pytest tests/test_ops.pypasses (17 tests).