Fix: Make the config field optional#1309
Merged
sudo-bmitch merged 1 commit intoopencontainers:mainfrom Feb 26, 2026
Merged
Conversation
sudo-bmitch
requested review from
cyphar,
jonjohnsonjr,
sajayantony,
stevvooe and
tianon
as code owners
tianon
reviewed
Feb 19, 2026
A struct in Go cannot be empty. The option added in 1.24 to support this is omitzero. Older versions of Go will ignore an unknown struct tag which is the same as the current behavior. Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
force-pushed
the
pr-optional-config
branch
from
6e4edd3 to
fccd049
Compare
tianon
approved these changes
Feb 20, 2026
sajayantony
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A struct in Go cannot be empty (unlike a pointer) and will never match the "omitempty" feature in the json package. The option added in 1.24 to support this is omitzero. Older versions of Go will ignore an unknown struct tag which is the same as the current behavior.
This came up when running
go fix ./...in some other code that had a copy of the struct. Our config docs already indicates the field is optional. And the json schema only lists architecture, os, and rootfs as the required fields (matching the docs and rest of the Go spec).