fix: preserve catalog and staff checks for authZ about-page access

[BryanttV]

Description

When AuthZ course authoring is enabled for a course, can_see_about_page previously checked only COURSES_VIEW_COURSE and ignored catalog visibility and staff bypass. Learners, data researchers, beta testers, and course staff could be blocked from the about page even when legacy rules would have allowed access.

Supporting information

• [Test failure] TC-00598: User cannot access course content and the about page when RBAC is enabled wg-build-test-release#585

Testing instructions

Note

RBAC must be enabled globally, at the organization level, or for specific courses.

1. As a learner (or beta tester/data researcher), access the course's about page; you should be able to view it without any issues.
2. As a learner (or beta tester/data researcher), go to the course home; you should be able to see the course content without any issues.

Modify the Catalog Visibility Setting and Public Course Content from Studio > Advanced Settings. Everything should work according to the configuration (docs)

Screenshots

Before

After

Deadline

Verawood

[openedx-webhooks]

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[MaferMazu]

Thanks for this fix @BryanttV ✨
This looks good. I just have a question and a suggestion related to it.

[MaferMazu]

Why do we need this change? Is it not better to maintain the behavior of not showing the info if the user is unauthorized, even though it is visible in the catalog? - Or is there a view that needs this?

[MaferMazu]

If we need this, we should modify the test name and add more tests to make our intentions explicit (for example, test that if it is visible in the catalog, it is visible for everyone, or other cases). This applies to the modifications on test_user_gains_access_after_role_assignment as well.