fix(example): resolve react/react-native from the example app#6
Merged
Conversation
In this library+example layout, npm auto-installs the library's peerDependencies
(expo, react, react-native) at their latest versions into the repo-root
node_modules. The example's Metro watches the monorepo root, so codegen could pull
the root's newer react-native and fail ("Unable to determine event arguments" in
VirtualViewNativeComponent). Pin the react/react-native singletons to the example's
own node_modules and block the root copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In this library + example layout, npm auto-installs the library's
peerDependencies(expo,react,react-native) at their latest versions into the repo-rootnode_modules. The example's Metro watches the monorepo root, so React Native codegen could pull the root's newerreact-nativeand fail:Fix
example/metro.config.js: pin thereact/react-nativesingletons to the example's ownnode_modules(extraNodeModules) and block the root copies (blockList). This makesexpo run:android/expo startbundle reliably.