Fix aggregate deserial function signature#2354
Draft
eeeebbbbrrrr wants to merge 1 commit into
Draft
Conversation
Remove the spurious aggregate-state argument from generated deserial functions and model PostgreSQL's required (bytea, internal) -> internal contract directly in the Aggregate trait. Add macro and live PostgreSQL regression coverage.\n\nFixes #2351
eeeebbbbrrrr
marked this pull request as draft
July 13, 2026 17:54
Contributor
Author
|
I am not sure that the attempt here is actually correct or in the spirit of pgrx. Having a function signature that takes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(bytea, internal) -> internalsignatureAggregate::deserialto mirror that contract without a spurious current-state argument orPgBoxconversioninternalstateFixes #2351
Testing
cargo test -p pgrx-sql-entity-graphcargo pgrx test pg18 aggregate_parallel_internal_deserialcargo check -p pgrx --no-default-features --features pg18cargo check -p pgrx-unit-tests --no-default-features --features pg18,pg_testcargo check --manifest-path pgrx-examples/aggregate/Cargo.toml --no-default-features --features pg18cargo clippy -p pgrx-sql-entity-graph -- -D warnings