ci: fallback on static-php.dev mirror when php.net is down#2233
Open
ci: fallback on static-php.dev mirror when php.net is down#2233
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves CI resilience when php.net’s releases API is unavailable (e.g., blocked by the php.net CDN) by adding a fallback mechanism to infer the latest PHP patch version via GitHub.
Changes:
- Add php.net → GitHub (
gh) fallback logic to determine the latest PHP version whenPHP_VERSIONisn’t set. - Update the sanitizers workflow to use the same fallback and to handle fetching either php.net
.xzarchives or GitHub.tar.gzarchives.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build-static.sh | Adds php.net API lookup with a GitHub (gh) fallback to resolve the latest patch version for a given minor series. |
| .github/workflows/sanitizers.yaml | Adds fallback logic for determining the PHP version and adjusts extraction to support GitHub tarballs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dunglas
force-pushed
the
ci/php-api-fallback
branch
from
09980a4 to
a809afc
Compare
dunglas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, GitHub Actions is often blocked by the php.net CDN. This patch adds a fallback to use GitHub to try to determine the PHP version to use. This is less ideal because PHP currently doesn't use GitHub extensively, and distribution archives aren't available in the GitHub releases, only on php.net.