Update documentation and error handling for Viva Connections Dashboard ACE commands to reflect support for Team and Communication sites#5351
Merged
Conversation
…d ACE commands to reflect support for Team and Communication sites
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Viva Connections Dashboard ACE cmdlets to no longer require the connected site to be a SharePoint Home Site, aligning behavior and documentation with dashboards being supported on Team and Communication sites (Fixes #5349).
Changes:
- Removed Home Site validation and instead operate based on whether a Viva dashboard is present on the connected web.
- Updated error handling paths to report when a dashboard cannot be found.
- Updated cmdlet documentation synopsis text to reflect Team/Communication site support.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Commands/Viva/AddVivaConnectionsDashboardACE.cs | Removes Home Site gate; adds “dashboard exists” check and error path. |
| src/Commands/Viva/RemoveVivaConnectionsDashboardACE.cs | Removes Home Site gate; adds “dashboard exists” check and error path. |
| src/Commands/Viva/SetVivaConnectionsDashboardACE.cs | Removes Home Site gate; adds “dashboard exists” check and error path. |
| src/Commands/Viva/GetVivaConnectionsDashboardACE.cs | Removes Home Site gate; now directly queries dashboard/ACEs (needs additional null-safety). |
| documentation/Add-PnPVivaConnectionsDashboardACE.md | Updates synopsis/description to indicate Team/Communication site support. |
| documentation/Remove-PnPVivaConnectionsDashboardACE.md | Updates synopsis to indicate Team/Communication site support. |
| documentation/Get-PnPVivaConnectionsDashboardACE.md | Updates synopsis to indicate Team/Communication site support. |
| documentation/Set-PnPVivaConnectionsDashboardACE.md | Updates synopsis to indicate Team/Communication site support. |
…d ACE commands to specify SharePoint Team site requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #5349
What is in this Pull Request ?
Updated code to remove the home site validation and allow ACE to be added