Skip to content

Push margin-top of TimelineBody +1px#7595

Open
llastflowers wants to merge 5 commits intomainfrom
llastflowers/2252026/timeline-icon-alignment-fix
Open

Push margin-top of TimelineBody +1px#7595
llastflowers wants to merge 5 commits intomainfrom
llastflowers/2252026/timeline-icon-alignment-fix

Conversation

@llastflowers
Copy link
Contributor

Closes https://github.com/github/primer/issues/6438

Changelog

Changed

Added +1px to the margin-top of TimelineBody to improve visual alignment of elements

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Good test stories:

Merge checklist

@llastflowers llastflowers requested a review from a team as a code owner February 25, 2026 21:24
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: c5f8f55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 25, 2026
@github-actions
Copy link
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Timeline component’s visual spacing to better align TimelineBody content with surrounding Timeline elements, addressing primer issue #6438.

Changes:

  • Increases TimelineBody top margin by 1px via calc() to improve vertical alignment.
  • Adds a targeted stylelint disable for the spacing rule on the updated declaration.

@llastflowers llastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 25, 2026
@github-actions github-actions bot temporarily deployed to storybook-preview-7595 February 25, 2026 21:34 Inactive
@primer primer bot requested a review from a team as a code owner February 25, 2026 21:40
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 25, 2026
@github-actions github-actions bot temporarily deployed to storybook-preview-7595 February 25, 2026 21:50 Inactive
max-width: 100%;
margin-top: var(--base-size-4);
/* stylelint-disable-next-line primer/spacing */
margin-top: calc(var(--base-size-4) + 1px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the 1px calc feels icky to me, try with.

Suggested change
margin-top: calc(var(--base-size-4) + 1px);
margin-top: 0.25lh;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally avoid using lh (and don't currently have any uses in our repo) because of Safari compatibility issues. We'd have to suppress the lint warning and provide a fallback value to cover unsupported browsers, which ends up being less clean overall. This calc() pattern is what we usually use when we need an in-between value not directly provided by our existing CSS variables, so I lean toward keeping things consistent.

@HiroAgustin
Copy link
Contributor

@copilot add patch changeset

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/14686

@primer-integration
Copy link

Integration test results from github/github-ui:

Passed  CI   Passed
Running  VRT   Running
Passed  Projects   Passed

@llastflowers llastflowers added the integration-tests: skipped manually Changes in this PR do not require an integration test label Feb 26, 2026
@llastflowers
Copy link
Contributor Author

integration tests passing but VRT status is not reporting here. Added skip label to unblock this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants